On 11/06/2023 02:32, Daniel Golle wrote: > Introduce DT bindings for the MT7988 SoC to mediatek,net.yaml. > The MT7988 SoC got 3 Ethernet MACs operating at a maximum of > 10 Gigabit/sec supported by 2 packet processor engines for > offloading tasks. > The first MAC is hard-wired to a built-in switch which exposes > four 1000Base-T PHYs as user ports. > It also comes with built-in 2500Base-T PHY which can be used > with the 2nd GMAC. > The 2nd and 3rd GMAC can be connected to external PHYs or provide > SFP(+) cages attached via SGMII, 1000Base-X, 2500Base-X, USXGMII, > 5GBase-KR or 10GBase-KR. > > Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> > --- > .../devicetree/bindings/net/mediatek,net.yaml | 111 ++++++++++++++++++ > 1 file changed, 111 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml > index acb2b2ac4fe1e..f08151a60084b 100644 > --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml > @@ -23,6 +23,7 @@ properties: > - mediatek,mt7629-eth > - mediatek,mt7981-eth > - mediatek,mt7986-eth > + - mediatek,mt7988-eth > - ralink,rt5350-eth > > reg: > @@ -70,6 +71,22 @@ properties: > A list of phandle to the syscon node that handles the SGMII setup which is required for > those SoCs equipped with SGMII. > > + mediatek,toprgu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the mediatek toprgu controller used to provide various clocks > + and reset to the system. > + > + mediatek,usxgmiisys: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 2 > + maxItems: 2 > + items: > + maxItems: 1 > + description: > + A list of phandle to the syscon node that handles the USXGMII setup which is required for > + those SoCs equipped with USXGMII. Why do you need two phandles for the same node? > + > mediatek,wed: > $ref: /schemas/types.yaml#/definitions/phandle-array > minItems: 2 > @@ -84,6 +101,21 @@ properties: > description: > Phandle to the mediatek wed-pcie controller. > > + mediatek,xfi_pextp: Underscores are not allowed in property names. > + $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 2 > + maxItems: 2 > + items: > + maxItems: 1 > + description: > + A list of phandle to the syscon node that handles the XFI setup which is required for > + those SoCs equipped with XFI. > + > + mediatek,xfi_pll: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the XFI PLL unit. This looks like a clock. > + > dma-coherent: true > > mdio-bus: > @@ -290,6 +322,85 @@ allOf: > minItems: 2 > maxItems: 2 > > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt7988-eth > + then: > + properties: > + interrupts: > + minItems: 4 > + > + clocks: > + minItems: 34 > + maxItems: 34 > + > + clock-names: > + items: > + - const: crypto > + - const: fe > + - const: gp2 > + - const: gp1 > + - const: gp3 > + - const: ethwarp_wocpu2 > + - const: ethwarp_wocpu1 > + - const: ethwarp_wocpu0 > + - const: esw > + - const: netsys0 > + - const: netsys1 > + - const: sgmii_tx250m > + - const: sgmii_rx250m > + - const: sgmii2_tx250m > + - const: sgmii2_rx250m > + - const: top_usxgmii0_sel > + - const: top_usxgmii1_sel > + - const: top_sgm0_sel > + - const: top_sgm1_sel > + - const: top_xfi_phy0_xtal_sel > + - const: top_xfi_phy1_xtal_sel > + - const: top_eth_gmii_sel > + - const: top_eth_refck_50m_sel > + - const: top_eth_sys_200m_sel > + - const: top_eth_sys_sel > + - const: top_eth_xgmii_sel > + - const: top_eth_mii_sel > + - const: top_netsys_sel > + - const: top_netsys_500m_sel > + - const: top_netsys_pao_2x_sel > + - const: top_netsys_sync_250m_sel > + - const: top_netsys_ppefb_250m_sel > + - const: top_netsys_warp_sel > + - const: wocpu1 > + - const: wocpu0 > + - const: xgp1 > + - const: xgp2 > + - const: xgp3 > + > + mediatek,sgmiisys: > + minItems: 2 > + maxItems: 2 > + > + mediatek,usxgmiisys: > + minItems: 2 > + maxItems: 2 Why do you need this here? > + > + mediatek,xfi_pextp: > + minItems: 2 > + maxItems: 2 > + > + mediatek,xfi_pll: > + minItems: 1 > + maxItems: 1 > + > + mediatek,infracfg: > + minItems: 1 > + maxItems: 1 > + > + mediatek,toprgu: > + minItems: 1 > + maxItems: 1 All this looks redundant. Best regards, Krzysztof
