On 12/06/2023 16.20, Rob Herring wrote: > On Mon, Jun 12, 2023 at 02:36:03PM +0200, Rasmus Villemoes wrote: >> On 12/06/2023 14.26, Rob Herring wrote: >>> >>> On Mon, 12 Jun 2023 13:30:52 +0200, Rasmus Villemoes wrote: >>>> Move the isil,isl12022 RTC bindings from trivial-rtc.yaml into its own >>>> intersil,isl12022.yaml file, in preparation for adding more bindings. >>>> >>>> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> >>>> --- >>>> .../bindings/rtc/intersil,isl12022.yaml | 42 +++++++++++++++++++ >>>> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - >>>> 2 files changed, 42 insertions(+), 2 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >>>> >>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml: 'maintainers' is a required property >>> hint: Metaschema for devicetree binding documentation >>> from schema $id: http://devicetree.org/meta-schemas/base.yaml# >> >> Hm ok. Can/should I copy the value from the trivial-rtc.yaml? Alexandre, >> would that be ok with you? > > Alexandre agreed, but in general the maintainer here should be someone > that has the h/w and/or cares about it, not subsystem maintainers. OK. Right now I have the hardware and care about it because I've been hired to work on it. Incidentally, my backlog for this project/product also contains upstreaming of a new gpiochip driver and DT bindings. I assume I should just list myself as maintainer in that new .yaml file, even if I can't promise to have time to review changes and/or even hardware to test on 12 months from now. Rasmus
