On 13/06/2023 09:30, Xu Yang wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Saturday, June 10, 2023 12:44 AM >> To: Xu Yang <xu.yang_2@xxxxxxx>; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx >> Cc: shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx <linux- >> imx@xxxxxxx>; linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- >> usb@xxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx> >> Subject: [EXT] Re: [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format >> >> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the >> message using the 'Report this email' button >> >> >> On 08/06/2023 05:36, Xu Yang wrote: >>> Convert the binding to DT schema format. Besides, this also add other >>> optional properties not contained in txt file. >> >> Why ones do you add? > > I add clock, power-domains and phy-3p0-supply to this doc. Because > the txt file should contain these properties but it not. I think the > txt doesn't get update in time. Can you mention them in commit msg? > >>> + reg: >>> + minItems: 1 >>> + maxItems: 2 >> >> You should list the items. >> >>> + >>> + interrupts: >>> + minItems: 1 >>> + maxItems: 2 >> >> You should list the items. > > After my check, the maxItems value of reg and interrupts should be 1. > Will change it. OK Best regards, Krzysztof
