On 10/06/2023 18:52, Stephan Gerhold wrote: > On Sat, Jun 10, 2023 at 06:43:17PM +0200, Krzysztof Kozlowski wrote: >> On 08/06/2023 09:10, Stephan Gerhold wrote: >>> On Qualcomm platforms, most subsystems (e.g. audio/modem DSP) are >>> described as remote processors in the device tree, with a dedicated >>> node where properties and services related to them can be described. >>> + >>> + smd-edge: >>> + $ref: /schemas/remoteproc/qcom,smd-edge.yaml# >>> + description: >>> + Qualcomm Shared Memory subnode which represents communication edge, >>> + channels and devices related to the RPM subsystem. >>> + >>> + glink-rpm: >> >> This should be "glink-edge", to be a bit more generic and match existing >> smd-edge. >> > > I fully agree and I actually made that change at some point before > sending v1. Unfortunately, it doesn't work: The node name "glink-edge" > is already reserved by qcom,glink-edge.yaml. While it's very similar it > has some subtle differences to glink-rpm-edge.yaml. For example, there > is no qcom,remote-pid in the RPM variant which is required by the normal > glink-edge. But the other variant has, so they are pretty similar. It could be one binding or some common part. Anyway we can as well drop the nodename from the qcom,glink-edge.yaml binding. Anyway the binding is referenced by each specific remote proc, so this nodename brings nothing. > Would "glink-rpm-edge" sound better? > > Thanks, > Stephan > Best regards, Krzysztof
