On Sat, 10 Jun 2023 18:30:57 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 10/06/2023 16:36, Shreeya Patel wrote: > > rk3588-saradc isn't compatible with the rk3399-saradc variant, > > hence, fix the following dtbs_check warning for 'oneOf' condition > > failure. > > > > Are you sure it isn't compatible? According to your driver it is and > this change is not enough. I'm not following. the rk3588 has separate handling from the rk3399 Separate devices specific structure for instance rk3588_saradc_data vs rk3399_saradc_data as provided as the match data for the different compatibles.. Looks to be incompatible to me. > > Best regards, > Krzysztof >