On Tue, Jun 06, 2023 at 10:06:05AM +0800, cong yang wrote: > Hi,Conor, > > On Mon, Jun 5, 2023 at 6:20 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > Hey Cong Yang, > > > > On Mon, Jun 05, 2023 at 02:05:23PM +0800, Cong Yang wrote: > > > Add an ilitek touch screen chip ili9882t. > > > > Could you add a comment here mentioning the relationship between these > > chips? > > Okay, I will add in V3 version. > > > On Mon, Jun 05, 2023 at 02:05:23PM +0800, Cong Yang wrote: > > > > > Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > --- > > > .../bindings/input/elan,ekth6915.yaml | 23 ++++++++++++++++--- > > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > > index 05e6f2df604c..f0e7ffdce605 100644 > > > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > > @@ -15,11 +15,14 @@ description: > > > > > > properties: > > > compatible: > > > - items: > > > - - const: elan,ekth6915 > > > + enum: > > > + - elan,ekth6915 > > > + - ilitek,ili9882t > > > > > > reg: > > > - const: 0x10 > > > + enum: > > > + - 0x10 > > > + - 0x41 > > > > Is 0x10 only valid for the elan,ekth6915 & 0x41 for the ilitek one? > > If so, please add some enforcement of the values based on the > > compatible. > > I don't think 0x10 is the only address for ekth6915,(nor is 0x41 the > only address for ili9882t). It depends on the hardware design. I'd just drop the values as we don't typically enforce 'reg' values. Rob
