On Fri, Jun 09, 2023 at 09:29:51PM +0200, Krzysztof Kozlowski wrote: > On 09/06/2023 19:40, Raymond Hackley wrote: > > On Friday, June 9th, 2023 at 3:46 PM, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > Second condition regulator_is_enabled(pvdd) is to make sure that pvdd is > > disabled with balance. > So you have buggy code and to hide the bug you add checks? No, make the > code correct so the check is not needed. Specifically your driver should only ever call regulator_disable() to balance out regulator_enable() calls it made itself and it should know how many of those it has done. regulator_is_enabled() should only ever be used during probe if for some reason it is important to figure out if the device is already powered for startup, this should be very unusual. If something else enabled the regualtor then whatever did that needs to undo those enables, not another driver.
Attachment:
signature.asc
Description: PGP signature
