On 9.06.2023 13:47, Krishna chaitanya chundru wrote: > Some platforms may not boot if a device driver doesn't initialize > the interconnect path. Mostly it is handled by the bootloader but > we have starting to see cases where bootloader simply ignores them. > > Add the "pcie-mem" interconnect path as a required property to the > bindings. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx> > --- Hi, only patches 1 and 2 made it to both me and linux-arm-msm. Consider using b4 (https://b4.docs.kernel.org/en/latest/index.html) to avoid this. > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > index b3c22eb..656e362 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > @@ -70,6 +70,13 @@ properties: > description: GPIO used as WAKE# output signal > maxItems: 1 > > + interconnects: > + maxItems: 1 > + > + interconnect-names: > + items: > + - const: pcie-mem > + > resets: > maxItems: 1 > > @@ -97,6 +104,8 @@ required: > - interrupts > - interrupt-names > - reset-gpios > + - interconnects > + - interconnect-names > - resets > - reset-names > - power-domains > @@ -194,6 +203,8 @@ examples: > interrupt-names = "global", "doorbell"; > reset-gpios = <&tlmm 57 GPIO_ACTIVE_LOW>; > wake-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>; > + interconnects = <&system_noc MASTER_PCIE_0 &mc_virt SLAVE_EBI1>; > + interconnect-names = "pci-mem"; The indentation is off and my brain compiler says that it will not compile without including some headers. Konrad > resets = <&gcc GCC_PCIE_BCR>; > reset-names = "core"; > power-domains = <&gcc PCIE_GDSC>;
