From: Florian Fainelli <f.fainelli@xxxxxxxxx>
On Thu, 8 Jun 2023 17:36:27 +0200, Christian Lamparter <chunkeey@xxxxxxxxx> wrote:
> | bcm53015-meraki-mr26.dtb: nand-controller@18028000:
> | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs']
> | From schema: Documentation/[...]/nand-controller.yaml
> | bcm53016-meraki-mr32.dtb: nand-controller@18028000:
> | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs']
> | From schema: Documentation/[...]/nand-controller.yaml
>
> original ECC values for these old Merakis are sadly not
> provided by the vendor. It looks like Meraki just stuck
> with what Broadcom's SDK was doing... which left this
> up to the proprietary nand driver.
>
> Note: The invalid setting was and is handled by brcmnand. It
> falls back to "bch" in brcmnand_setup_dev() when ecc.algo is
> set to NAND_ECC_ALGO_UNKNOWN (since "hw" is not in the list
> above).
>
> A correct nand-ecc-algo = "bch"; is already specified in the
> included "bcm5301x-nand-cs0-bch8.dtsi". So this line can be
> dropped.
>
> Reported-by: Rafał Miłecki <zajec5@xxxxxxxxx> (per Mail)
> Fixes: 935327a73553 ("ARM: dts: BCM5301X: Add DT for Meraki MR26")
> Fixes: ec88a9c344d9 ("ARM: BCM5301X: Add DT for Meraki MR32")
> Signed-off-by: Christian Lamparter <chunkeey@xxxxxxxxx>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
