On 07/06/2023 10:05, Neil Armstrong wrote: > Add nodes to support Type-C USB/DP functionality. > Thank you for your patch. There is something to discuss/improve. > + > +&i2c_hub_2 { > + status = "okay"; > + > + fsa4480@42 { > + compatible = "fcs,fsa4480"; > + reg = <0x42>; > + > + vcc-supply = <&vreg_bob1>; > + > + mode-switch; > + orientation-switch; > + svid = /bits/ 16 <0xff01>; I think this property is not documented. Best regards, Krzysztof