Re: [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: Remove assigned-clock* properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 08, 2023 at 09:31:57AM +0200, Alexander Stein wrote:
> Hi Conor,
> 
> Am Dienstag, 6. Juni 2023, 20:21:02 CEST schrieb Conor Dooley:
> > * PGP Signed by an unknown key
> > 
> > On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> > > These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> > > more than just one clock using these properties.
> > 
> > What does "allowed anyway" mean?
> > And following from that, why not modify the min/maxItems to suit
> > reality, rather than remove them. Is there enforcement from elsewhere?
> 
> As Liu pointed out, assigned-clock* were considered a generic property added 
> by default at that time. With that support added there is no need to specify 
> these properties in this bindings again.
> Despite that you never know in advance how many items you will have to add to 
> assigned-clock* properties, that's totally different to 'clocks', it may even 
> depend on board specific clock setups.

Sounds grand to me. I think it'd be good in the future to explain
*where* the enforcement comes from, rather than saying something like
"allowed anyway". Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux