Update: It seems device tree doesn't accept enum. I'll use #define here. On Thu, 2023-06-08 at 11:01 +0800, shawn.sung wrote: > Hi AngeloGioacchino, > > Should I use enum instead of #define if reset ID must starts from 0? > > Thanks, > Hsiao Chien Sung > > On Wed, 2023-06-07 at 09:51 +0200, AngeloGioacchino Del Regno wrote: > > > > External email : Please do not click links or open attachments > > until > > you have verified the sender or the content. > > > > Il 07/06/23 08:11, Hsiao Chien Sung ha scritto: > > > Add reset control bits for MT8188 VDOSYS1. > > > > > > Signed-off-by: Hsiao Chien Sung <shawn.sung@xxxxxxxxxxxx> > > > --- > > > include/dt-bindings/reset/mt8188-resets.h | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/include/dt-bindings/reset/mt8188-resets.h > > > > b/include/dt-bindings/reset/mt8188-resets.h > > > index 377cdfda82a9..439a9a25ca19 100644 > > > --- a/include/dt-bindings/reset/mt8188-resets.h > > > +++ b/include/dt-bindings/reset/mt8188-resets.h > > > @@ -33,4 +33,16 @@ > > > > > > #define MT8188_TOPRGU_SW_RST_NUM 24 > > > > > > +/* VDOSYS1 */ > > > +#define MT8188_VDO1_RST_MERGE0_DL_ASYNC 9 > > > > Sorry, I've just noticed that there's no index 0 in previous > > definitions: this > > is wrong, it must start from 0 and must be sequential. > > > >
