On Wed, Jun 07, 2023 at 09:49:18PM +0200, Tommaso Merciai wrote:
> On Wed, Jun 07, 2023 at 06:16:19PM +0100, Conor Dooley wrote:
> > On Wed, Jun 07, 2023 at 03:19:24PM +0200, Tommaso Merciai wrote:
> You are suggesting the following solution:
>
> minimum: 1
> maximum: 150000
>
> Right?
>
> Personally I prefer to keep also 0 but never mind
> is ok also this solution. :)
>
> Let me know if I have understood correctly pls.
> Thanks in advance :)
Yup, you got it.
> > > +static int alvium_get_dt_data(struct alvium_dev *alvium)
> > > +{
> > > + struct device *dev = &alvium->i2c_client->dev;
> > > + struct device_node *node = dev->of_node;
> > > + struct fwnode_handle *endpoint;
> > > + int ret = 0;
> > > +
> > > + if (!node)
> > > + return -EINVAL;
> > > +
> > > + ret = fwnode_property_read_u32(dev_fwnode(dev),
> > > + "alliedvision,lp2hs-delay-us",
> > > + &alvium->lp2hs_delay);
> > > + if (ret)
> > > + dev_info(dev, "lp2hs-delay-us not found\n");
> >
> > And this print, which I also don't understand the presence of as
> > well behaving driver should be quiet, goes away.
>
> Then you are suggesting to drop this print right?
Yeah, in general we do not want drivers to be printing things while they
are behaving correctly & not having the property isn't an error ;)
Cheers,
Conor.
Attachment:
signature.asc
Description: PGP signature
