Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx> writes: >>>>> + >>>>> + properties: >>>>> + compatible: >>>>> + enum: >>>>> + - qcom,ipq5018-wcss-ahb-mpd >>>>> + - qcom,ipq9574-wcss-ahb-mpd >>>>> + - qcom,ipq5018-wcss-pcie-mpd >>>> >>>> Keep rather alphabetical order (so both 5018 together). >>>> >>>> I also do not understand these at all. Why adding bus type to >>>> compatible? This rarely is allowed (unless it is PCIe controller within >>>> soc). >>>> >>> IPQ5018 SOC has in-built PCIE controller. Here QDSP6 will bring up >>> external(PCIE) and internal (AHB) wifi radio's. To separate AHB, PCIE >>> radio's properties, i have added bus type to compatible. >> >> It's the same device - WCSS - right? We do not create multiple nodes and >> compatibles for the same devices. Bus suffixes are almost never parts of >> compatibles. > > > No it's not the same device. WCSS on inside IPQ5018 and WCSS attached > via pcie to IPQ5018. Here QDSP6 managing both WCSS's. > > So for better clarity i will use attached SOC ID in compatible. > Below are the new compatible's. > > - qcom,ipq5018-wcss-mpd //IPQ5018 internal radio > - qcom,ipq9574-wcss-mpd //IPQ9574 internal radio > - qcom,qcn6122-wcss-mpd //IPQ5018 attached radio What mandates that there's just one QCN6122 device attached to PCI? Assuming fixed PCI configurations like that makes me worried. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
