On Sun Jun 4, 2023 at 6:30 AM EDT, Krzysztof Kozlowski wrote: > On 04/06/2023 08:30, Rudraksha Gupta wrote: > > Adds qcom,usb-hs-phy-msm8960 compatible > > > > Signed-off-by: Rudraksha Gupta <guptarud@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > > index aa97478dd016..63b6914993fe 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > > @@ -13,7 +13,9 @@ if: > > properties: > > compatible: > > contains: > > - const: qcom,usb-hs-phy-apq8064 > > + items: > > + - const: qcom,usb-hs-phy-apq8064 > > + - const: qcom,usb-hs-phy-msm8960 > > I have no clue what you want to achieve here. You break the bindings. When I added the USB node to the msm8960 dtsi file, I got similar messages for the expressatt/cdp that Rob mentioned in his email reply: phy: resets: [[25, 0]] is too short phy: reset-names:0: 'phy' was expected phy: reset-names: ['por'] is too short I will send an updated patch soon that addresses this. > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. > > Best regards, > Krzysztof Sorry. I was only looking for expressatt errors/warnings and failed to see the other errors/warnings in the sea of text.
