On Mon, Jun 05, 2023 at 08:53:21PM +0200, Konrad Dybcio wrote: > > > On 5.06.2023 09:08, Stephan Gerhold wrote: > > Avoid having to look up a dummy item from SMEM to detect if it is > > already available or if we need to defer probing. > > > > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > > --- > > drivers/soc/qcom/smem.c | 9 +++++++++ > > include/linux/soc/qcom/smem.h | 1 + > > 2 files changed, 10 insertions(+) > > > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > > index b0d59e815c3b..3d93a6681494 100644 > > --- a/drivers/soc/qcom/smem.c > > +++ b/drivers/soc/qcom/smem.c > > @@ -359,6 +359,15 @@ static struct qcom_smem *__smem; > > /* Timeout (ms) for the trylock of remote spinlocks */ > > #define HWSPINLOCK_TIMEOUT 1000 > > > > +/** > > + * qcom_smem_is_available() - Checks if SMEM is available > > + */ > Shouldn't kerneldoc explicitly say "returns x if y else z"? > Seems like yes but I copy-pasted from other examples in this file and there it is always missing. I'll add something simple in v2. Thanks, Stephan
