Hello Conor, pet, 19. svi 2023. u 18:41 Conor Dooley <conor@xxxxxxxxxx> napisao je: > > Hey Paulo, > > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote: > > > > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > > DCS initialization sequences with certain delays between certain > > commands. > > > > Signed-off-by: Paulo Pavacic <pavacic.p@xxxxxxxxx> > > --- > > v3 changelog: > > - renamed yml file > > - refactored yml file to describe fannal,c3004 > > - added matrix URI to MAINTAINERS > > v2 changelog: > > - revised driver title, now describes purpose > > - revised description, now describes hw > > - revised maintainers, now has only 1 mail > > - removed diacritics from commit/commit author > > - properties/compatible is now enum > > - compatible using only lowercase > > - revised dts example > > - modified MAINTAINERS in this commit (instead of driver commit) > > - dt_bindings_check checked yml > > - checkpatch warning fixed > > --- > > .../bindings/display/panel/fannal,c3004.yaml | 75 +++++++++++++++++++ > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > MAINTAINERS | 6 ++ > > 3 files changed, 83 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml > > new file mode 100644 > > index 000000000000..a86b5ce02aa2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml > > @@ -0,0 +1,75 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Fannal C3004 MIPI-DSI > > + > > +maintainers: > > + - Paulo Pavacic <pavacic.p@xxxxxxxxx> > > + > > +description: | > > + Fannal C3004 is a 480x800 panel which requires DSI DCS > > + initialization sequences. > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - const: fannal,c3004 > > + > > + reg: true > > Are there no restrictions on the number of reg entries? What do you mean by this? May I have some example if possible? > > > + reset-gpios: true > > Can you put a blank line between properties please? > > > + > > + vdd-supply: > > + description: power supply voltage > > + vddio-supply: > > + description: power supply voltage for IO > > + > > + width-mm: > > + description: physical panel width [mm] > > + height-mm: > > + description: physical panel height [mm] > > Here and for the supplies too. > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > index 82d39ab0231b..f962750f630a 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -462,6 +462,8 @@ patternProperties: > > description: Facebook > > "^fairphone,.*": > > description: Fairphone B.V. > > + "^fannal,.*": > > + description: Fannal Electronics Co., Ltd > > This needs to be split into a commit of its own. > > Thanks, > Conor. > > > "^faraday,.*": > > description: Faraday Technology Corporation > > "^fastrax,.*": > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5c22c828ab46..62374c8424b9 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > > F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml > > F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c > > > > +DRM DRIVER FOR FANNAL C3004373132019A > > +M: Paulo Pavacic <pavacic.p@xxxxxxxxx> > > +S: Maintained > > +C: matrix:r/mipi-dsi-bringup:matrix.org > > +F: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml > > + > > DRM DRIVER FOR FARADAY TVE200 TV ENCODER > > M: Linus Walleij <linus.walleij@xxxxxxxxxx> > > S: Maintained > > -- > > 2.40.1 > > Thanks, Paulo
