On 05/06/2023 14:07, Nicolas Ferre wrote:
> On 05/06/2023 at 08:42, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 03/06/2023 22:02, Varshini Rajendran wrote:
>>> From: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
>>>
>>> Add support for GMAC in sam9x7 SoC family
>>>
>>> Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx>
>>> Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
>>> ---
>>> drivers/net/ethernet/cadence/macb_main.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
>>> index 29a1199dad14..609c8e9305ba 100644
>>> --- a/drivers/net/ethernet/cadence/macb_main.c
>>> +++ b/drivers/net/ethernet/cadence/macb_main.c
>>> @@ -4913,6 +4913,7 @@ static const struct of_device_id macb_dt_ids[] = {
>>> { .compatible = "microchip,mpfs-macb", .data = &mpfs_config },
>>> { .compatible = "microchip,sama7g5-gem", .data = &sama7g5_gem_config },
>>> { .compatible = "microchip,sama7g5-emac", .data = &sama7g5_emac_config },
>>> + { .compatible = "microchip,sam9x7-gem", .data = &sama7g5_gem_config },
>>
>> These are compatible, aren't they? Why do you need new entry?
>
> The hardware itself is different, even if the new features are not
> supported yet in the macb driver.
> The macb driver will certainly evolve in order to add these features so
> we decided to match a new compatible string all the way to the driver.
You claim to be fully compatible with sama7g5-gem, so adding new
features does not warrant not-reusing old match entry now.
Best regards,
Krzysztof
