On 05/06/2023 15:04, Nicolas Ferre wrote:
> On 05/06/2023 at 08:43, Krzysztof Kozlowski wrote:
>> On 03/06/2023 22:02, Varshini Rajendran wrote:
>>> Use sam9x7 pmc's compatible to lookup for in the SHDWC driver
>>>
>>> Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx>
>>> ---
>>> drivers/power/reset/at91-sama5d2_shdwc.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
>>> index d8ecffe72f16..d0f29b99f25e 100644
>>> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
>>> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
>>> @@ -326,6 +326,7 @@ static const struct of_device_id at91_pmc_ids[] = {
>>> { .compatible = "atmel,sama5d2-pmc" },
>>> { .compatible = "microchip,sam9x60-pmc" },
>>> { .compatible = "microchip,sama7g5-pmc" },
>>> + { .compatible = "microchip,sam9x7-pmc" },
>>
>> Why do you need new entry if these are compatible?
>
> Yes, PMC is very specific to a SoC silicon. As we must look for it in
> the shutdown controller, I think we need a new entry here.
??? How does it answer to my question at all? What is exactly specific
which warrants new entry?
Best regards,
Krzysztof
