On Sun, Jun 04, 2023 at 11:20:43PM +0300, Maxim Kiselev wrote: > пт, 2 июн. 2023 г. в 11:38, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx>: > > On 02/06/2023 00:30, Maksim Kiselev wrote: > > > From: Maxim Kiselev <bigunclemax@xxxxxxxxx> > > > > > > Allwinner's D1/T113s/R329/T507 SoCs have a new general purpose ADC. > > > This ADC is the same for all of this SoCs. The only difference is > > > the number of available channels. > > > > Except that it wasn't tested... > > Yes, you are right. I tested it only on the T113s board. And I will be glad if > someone tests it on another SoC. I would imagine Krzysztof meant testing the binding w/ dt_binding_check etc, rather than testing the ADC itself. > > Please run scripts/checkpatch.pl and fix reported warnings. Some > > warnings can be ignored, but the code here looks like it needs a fix. > > Feel free to get in touch if the warning is not clear. > > I got a warning about required maintainer property. Should I do > anything with this? Yes, you should! > If yes, then who should be a maintainer? You, preferably. > > Hm? So you do not allow anything from adc.yaml related? Are you sure > > this is your intention? > > I'm not sure about it. I looked at other ADC bindings and didn't find > another driver with 'additionalProperties: true' Try `unevaluatedProperties: false` instead. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
