On Sat, Jun 03, 2023 at 10:19:50PM +0100, Conor Dooley wrote: > Hey Varshini, > > On Sun, Jun 04, 2023 at 01:32:37AM +0530, Varshini Rajendran wrote: > > Document the support added for the Advanced interrupt controller(AIC) > > chip in the sam9x7 soc family > > Please do not add new family based compatibles, but rather use per-soc > compatibles instead. These things leave me penally confused. Afaiu, sam9x60 is a particular SoC. sam9x7 is actually a family, containing sam9x70, sam9x72 and sam9x75. It would appear to me that each should have its own compatible, no? > > Cheers, > Conor. > > > > > Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/interrupt-controller/atmel,aic.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt b/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt > > index 7079d44bf3ba..2c267a66a3ea 100644 > > --- a/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt > > +++ b/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt > > @@ -4,7 +4,7 @@ Required properties: > > - compatible: Should be: > > - "atmel,<chip>-aic" where <chip> can be "at91rm9200", "sama5d2", > > "sama5d3" or "sama5d4" > > - - "microchip,<chip>-aic" where <chip> can be "sam9x60" > > + - "microchip,<chip>-aic" where <chip> can be "sam9x60", "sam9x7" > > > > - interrupt-controller: Identifies the node as an interrupt controller. > > - #interrupt-cells: The number of cells to define the interrupts. It should be 3. > > -- > > 2.25.1 > >
Attachment:
signature.asc
Description: PGP signature
