Sun, Jun 04, 2023 at 12:23:34AM +0530, Shreeya Patel kirjoitti: > From: Simon Xue <xxm@xxxxxxxxxxxxxx> > > Add new start and read functions to support rk3588 device. > Also, add a device compatible string for the same. ... > +/* v2 registers */ > +#define SARADC2_CONV_CON 0x0 > +#define SARADC_T_PD_SOC 0x4 > +#define SARADC_T_DAS_SOC 0xc Can you use fixed-width values for all registers? 0x000 0x004 0x00c > +#define SARADC2_END_INT_EN 0x104 > +#define SARADC2_ST_CON 0x108 > +#define SARADC2_STATUS 0x10c > +#define SARADC2_END_INT_ST 0x110 > +#define SARADC2_DATA_BASE 0x120 -- With Best Regards, Andy Shevchenko
