Re: [PATCH v3 11/12] dmaengine: fsl-edma: integrate v3 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 02, 2023 at 09:41:19AM +0000, Joy Zou wrote:
> > +	.chreg_off = EDMA_TCD,
> > +	.chreg_space_sz = sizeof(struct fsl_edma_hw_tcd),
> >  	.flags = FSL_EDMA_DRV_HAS_DMACLK | FSL_EDMA_DRV_CONFIG32,
> >  	.setup_irq = fsl_edma2_irq_init,
> >  };
> > 
> > +static struct fsl_edma_drvdata imx8qm_data = {
> > +	.flags = FSL_EDMA_DRV_HAS_CHMUX | FSL_EDMA_DRV_HAS_PD
> > +		 | FSL_EDMA_DRV_EDMA3,
> > +	.chreg_space_sz = 0x10000,
> > +	.chreg_off = 0x10000,
> > +	.setup_irq = fsl_edma3_irq_init,
> > +};
> Hi frank,
> There are many dma controllers in imx8qm. But not all dma controllers support ch-mux.
> In addition, Imx93 edma v3 also doesn't support ch-mux.
> You can confirm with RM. Can we use the dts node property instead of drvdata flags? 
> BR
> Joy Zou
> > +

I tested all i.mx8qxp have not ch-mux. did you find any one have ch-mux at imx8qm?
I will remove FSL_EDMA_DRV_HAS_CHMUX at imx8qm and imx93 at next version.
It works just because dmamuxs is 0. ch-mux register have not written at all.

we have compatible string, which are enough to distinguish the difference.
not neccesary to add property for that.

Frank Li

> > --
> > 2.34.1
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux