On 6/2/2023 6:41 PM, Andy Shevchenko wrote:
On Fri, Jun 2, 2023 at 11:24 AM Sricharan Ramabadhran
<quic_srichara@xxxxxxxxxxx> wrote:
Add support for the global clock controller found on IPQ5018
based devices.
...
config IPQ_GCC_5332
tristate "IPQ5332 Global Clock Controller"
depends on ARM64 || COMPILE_TEST
help
Support for the global clock controller on ipq5332 devices.
- Say Y if you want to use peripheral devices such as UART, SPI,
- i2c, USB, SD/eMMC, etc.
Nothing in the commit message about this. Please, elaborate.
...
oops, unintended change. Not sure how this crept in.
Thanks for catching it, will remove this.
+#include <linux/kernel.h>
+#include <linux/err.h>
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/clk-provider.h>
+#include <linux/regmap.h>
+#include <linux/reset-controller.h>
Why not keep this ordered?
Missing bits.h and maybe others, but in an unordered list it's harder to check.
sure, will order it.
...
+ &gpll4_main.clkr.hw
Can we keep trailing comma here and in similar cases, like
+ &ubi32_pll_main.clkr.hw
+ &gpll0_main.clkr.hw
(and many others)?
ok, will fix it.
Regards,
Sricharan
