On Thu, 01 Jun 2023 19:28:01 +0200 m.brock@xxxxxxxxxxxxx wrote: > Hugo Villeneuve schreef op 2023-06-01 18:31: > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > In preparation for upcoming patch "fix regression with GPIO > > configuration". To facilitate review and make code more modular. > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 6.1.x > > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > Reviewed-by: Lech Perczak <lech.perczak@xxxxxxxxxxxxxxx> > > Tested-by: Lech Perczak <lech.perczak@xxxxxxxxxxxxxxx> > > --- > > drivers/tty/serial/sc16is7xx.c | 39 ++++++++++++++++++++-------------- > > 1 file changed, 23 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/tty/serial/sc16is7xx.c > > b/drivers/tty/serial/sc16is7xx.c > > index 0c903d44429c..279d7dcb1447 100644 > > --- a/drivers/tty/serial/sc16is7xx.c > > +++ b/drivers/tty/serial/sc16is7xx.c > > @@ -1349,6 +1349,26 @@ static int > > sc16is7xx_gpio_direction_output(struct gpio_chip *chip, > > > > return 0; > > } > > + > > +static int sc16is7xx_setup_gpio_chip(struct device *dev) > > Only one parameter, but... > > > + ret = sc16is7xx_setup_gpio_chip(dev, mctrl_mask); > > called with two. Hi Maarten, sorry about that, I will fix this for V6. Somehow my automated compile script tested each patch separately, including this one, but the defconfig didn't enable the module sc6is7xx, so the error went unnoticed. I wrongly assumed that "make alldefconfig" enabled all modules, I will instead use "make allyesconfig". Hugo.
