On 01/06/2023 10:07, Xu Yang wrote: > Convert the binding to DT schema format. > Thank you for your patch. There is something to discuss/improve. e/bindings/phy/mxs-usb-phy.yaml b/Documentation/devicetree/bindings/phy/mxs-usb-phy.yaml > new file mode 100644 > index 000000000000..48b0e654e52c > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/mxs-usb-phy.yaml Filename matching compatibles, so for exmaple fsl,mxs-usbphy.yaml. > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/mxs-usb-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale MXS USB Phy Device > + > +maintainers: > + - Xu Yang <xu.yang_2@xxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx23-usbphy > + - fsl,vf610-usbphy > + - items: > + - enum: > + - fsl,imx28-usbphy > + - fsl,imx6ul-usbphy > + - fsl,imx6sl-usbphy > + - fsl,imx6sx-usbphy > + - fsl,imx6q-usbphy > + - const: fsl,imx23-usbphy > + - items: > + - enum: > + - fsl,imx7ulp-usbphy > + - fsl,imx6sll-usbphy > + - const: fsl,imx6ul-usbphy > + - const: fsl,imx23-usbphy > + - items: > + - const: fsl,imx8dxl-usbphy > + - const: fsl,imx7ulp-usbphy > + - const: fsl,imx6ul-usbphy > + - const: fsl,imx23-usbphy I cannot find these in the old bindings. Please explain changes to conversion in commit msg. So far you wrote that it is pure conversion. > + > + reg: > + minItems: 1 > + maxItems: 2 > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + > + fsl,anatop: > + description: > + phandle for anatop register, it is only for imx6 SoC series > + $ref: /schemas/types.yaml#/definitions/phandle-array > + maxItems: 1 > + > + fsl,tx-cal-45-dn-ohms: > + description: > + Resistance (in ohms) of switchable high-speed trimming resistor > + connected in parallel with the 45 ohm resistor that terminates > + the DN output signal. > + minimum: 35 > + maximum: 54 > + default: 45 > + > + fsl,tx-cal-45-dp-ohms: > + description: > + Resistance (in ohms) of switchable high-speed trimming resistor > + connected in parallel with the 45 ohm resistor that terminates > + the DP output signal. > + minimum: 35 > + maximum: 54 > + default: 45 > + > + fsl,tx-d-cal: > + description: > + Current trimming value (as a percentage) of the 17.78 mA TX > + reference current. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 79 > + maximum: 119 > + default: 100 > + > +required: > + - compatible > + - reg > + - interrupts > + missing allOf narrowing anatop to imx6. Also interrupts and reg should be narrowed to respective variants. > +unevaluatedProperties: false Instead additionalProperties: false. > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + usbphy1: usb-phy@20c9000 { > + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy"; > + reg = <0x020c9000 0x1000>; > + interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>; Is 0 known flag? Use defines for it. > + fsl,anatop = <&anatop>; > + }; > + > +... Best regards, Krzysztof
