On 01/06/2023 13:41, Sricharan Ramabadhran wrote: > > > On 6/1/2023 3:21 PM, Krzysztof Kozlowski wrote: >> On 01/06/2023 11:50, Sricharan Ramabadhran wrote: >>> >>> >>> On 5/29/2023 9:25 PM, andy.shevchenko@xxxxxxxxx wrote: >>>> Mon, May 29, 2023 at 03:58:09PM +0530, Sricharan Ramabadhran kirjoitti: >>>>> On 5/20/2023 12:17 AM, Andy Shevchenko wrote: >>>>>> On Fri, May 19, 2023 at 3:55 PM Sricharan Ramabadhran >>>>>> <quic_srichara@xxxxxxxxxxx> wrote: >>>> >>>> ... >>>> >>>>>> depends on OF || COMPILE_TEST >>>>> >>>>> Yeah sure. COMPILE_TEST could be standalone. Will fix it and repost. >>>> >>>> Standalone COMPILE_TEST will give you definitely NOT what you want. >>>> And actually it's strange to have it standalone. >>>> >>> >>> Ho ok, i meant like this, "depends on ARM64 || COMPILE_TEST" >> >> Don't do it differently than all other drivers. Open the Kconfig and >> look at existing entries. >> > The latest added has this below, will use this > > depends on OF || COMPILE_TEST I would even drop this... Lemme check, it looks odd. We depend on ARCH_QCOM which uses OF. We have few drivers which depend on ACPI, but that also seems wrong. These are platform drivers so they should expect platform select proper firmware interface. I think none of other platform drivers do like this (neither Samsung pinctrl nor other Qualcomm drivers)). I will fix this. For your patch I would just skip OF entirely. Best regards, Krzysztof
