On 5/24/23 16:01, Justin Chen wrote:
Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. This controller features two distinct Ethernet ports that can be independently operated. This patch supports: - Wake-on-LAN using magic packets - basic ethtool operations (link, counters, message level) - MAC destination address filtering (promiscuous, ALL_MULTI, etc.) Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> Signed-off-by: Justin Chen <justin.chen@xxxxxxxxxxxx> ---
[snip]
+static const struct net_device_ops bcmasp_netdev_ops = {
+ .ndo_open = bcmasp_open,
+ .ndo_stop = bcmasp_stop,
+ .ndo_start_xmit = bcmasp_xmit,
+ .ndo_tx_timeout = bcmasp_tx_timeout,
+ .ndo_set_rx_mode = bcmasp_set_rx_mode,
+ .ndo_get_phys_port_name = bcmasp_get_phys_port_name,
+ .ndo_get_stats = bcmasp_get_stats,
+ .ndo_do_ioctl = bcmasp_ioctl,
This needs to be:@@ -1207,7 +1196,7 @@ static const struct net_device_ops bcmasp_netdev_ops = {
.ndo_set_rx_mode = bcmasp_set_rx_mode,
.ndo_get_phys_port_name = bcmasp_get_phys_port_name,
.ndo_get_stats = bcmasp_get_stats,
- .ndo_do_ioctl = bcmasp_ioctl,
+ .ndo_eth_ioctl = phy_do_ioctl_running,
.ndo_set_mac_address = bcmasp_set_mac_address,
};
such that MII ioctls work properly.
--
Florian
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
