On 26/05/2023 14:29, Bryan O'Donoghue wrote: > On 25/05/2023 18:21, Jagadeesh Kona wrote: >> Add device tree bindings for the camera clock controller on >> Qualcomm SM8550 platform. >> >> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx> >> Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx> >> --- >> Changes since V1: >> - Removed new YAML file and reused SM8450 CAMCC YAML file for SM8550 >> >> .../bindings/clock/qcom,sm8450-camcc.yaml | 8 +- >> include/dt-bindings/clock/qcom,sm8550-camcc.h | 187 ++++++++++++++++++ >> 2 files changed, 193 insertions(+), 2 deletions(-) >> create mode 100644 include/dt-bindings/clock/qcom,sm8550-camcc.h >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml >> index 87ae74166807..8dbc9004202f 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml >> @@ -13,11 +13,15 @@ description: | >> Qualcomm camera clock control module provides the clocks, resets and power >> domains on SM8450. >> >> - See also:: include/dt-bindings/clock/qcom,sm8450-camcc.h >> + See also:: >> + include/dt-bindings/clock/qcom,sm8450-camcc.h >> + include/dt-bindings/clock/qcom,sm8550-camcc.h >> >> properties: >> compatible: >> - const: qcom,sm8450-camcc >> + enum: >> + - qcom,sm8450-camcc >> + - qcom,sm8550-camcc > > Hmm, > > So looking at Documentation/devicetree/bindings/clock/*camcc*.yaml we > seem to be repeating yaml over and over again with no substantial > difference between one description and another. > > You've picked at the thread here by adding sm8550 into sm8450. > > I think sm8250, sm8450, sm8550, sc7280 and ... probably sm6350 should > live in the one yaml description > Documentation/devicetree/bindings/clock/qcom,camcc.yaml > > sm6350 looks a bit sparse/incomplete to me so perhaps leave that out. > The others sc7280, sm8250, sm8450 and sm8550 can/should all be moved > into the same yaml file with a list of compatibles. Clocks are different. The ones with same clocks should be together, but in other cases better to have separate schemas. It gets trickier to read with multiple if:then: Best regards, Krzysztof
