On 30/05/2023 04:53, Stanley Chang[昌育德] wrote: >>> +properties: >>> + compatible: >>> + enum: >>> + - realtek,usb3phy >>> + - realtek,rtd-usb3phy >>> + - realtek,rtd1295-usb3phy >>> + - realtek,rtd1619-usb3phy >>> + - realtek,rtd1319-usb3phy >>> + - realtek,rtd1619b-usb3phy >>> + - realtek,rtd1319d-usb3phy > >> Ignoring everything else, because I really want Krzysztof or Rob to >> review this rather than me, but what's going on here with the >> compatibles? >> What hardware do "usbNphy" and "rtd-usbNphy" represent? >> >> You have device-specific compatibles, which is great, but you also allow >> only those two generic ones. I had a _brief_ look at the driver, and it >> seems like there is no decision making done based on the compatibles, >> only on the properties. Is that correct? >> If it is, I would understand having "realtek,usb3phy" as a fallback >> compatible for "realtek,rtd1619-usb3phy", but I do not get the current >> setup. > > This driver is compatible with all Realtek RTD SoCs without specifying different settings. > So use "realtek,usb3phy" as fallback compatible for all SoCs. Binding says something entirely else... Best regards, Krzysztof
