On 31.05.2023 14:22, Neil Armstrong wrote: > The Volume Down & Power buttons are controlled by the PMIC via > the PON hardware, and the Volume Up is connected to a PMIC gpio. > > Enable the necessary hardware and setup the GPIO state for the > Volume Up gpio key. > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 36 +++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > index efff15225e67..24fc368de97b 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > @@ -54,6 +54,22 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&volume_up_n>; property-n property-names Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > + > + key-volume-up { > + label = "Volume Up"; > + linux,code = <KEY_VOLUMEUP>; > + gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>; > + debounce-interval = <15>; > + linux,can-disable; > + wakeup-source; > + }; > + }; > + > pmic-glink { > compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink"; > #address-cells = <1>; > @@ -516,6 +532,16 @@ led-1 { > }; > }; > > +&pm8550_gpios { > + volume_up_n: volume-up-n-state { > + pins = "gpio6"; > + function = "normal"; > + power-source = <1>; > + bias-pull-up; > + input-enable; > + }; > +}; > + > &pm8550_pwm { > status = "okay"; > > @@ -548,6 +574,16 @@ &pm8550b_eusb2_repeater { > vdd3-supply = <&vreg_l5b_3p1>; > }; > > +&pon_pwrkey { > + status = "okay"; > +}; > + > +&pon_resin { > + linux,code = <KEY_VOLUMEDOWN>; > + > + status = "okay"; > +}; > + > &pcie_1_phy_aux_clk { > clock-frequency = <1000>; > }; >