Re: [PATCH 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/31/2023 12:45 PM, Krzysztof Kozlowski wrote:
On 31/05/2023 08:56, Sridharan S N wrote:
Add support for wlan-2g LED on GPIO 36 and wps buttons on GPIO 35.

Signed-off-by: Sridharan S N <quic_sridsn@xxxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 43 +++++++++++++++++++++
  arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts | 43 +++++++++++++++++++++
  arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 43 +++++++++++++++++++++
  3 files changed, 129 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
index 3af1d5556950..ba733b6cab06 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
+++ b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
@@ -7,6 +7,8 @@
/dts-v1/; +#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
  #include "ipq5332.dtsi"
/ {
@@ -20,6 +22,33 @@
  	chosen {
  		stdout-path = "serial0";
  	};
+
+	gpio_keys {
No underscores in node names.
Will address it in V2

+		compatible = "gpio-keys";
+		pinctrl-0 = <&gpio_keys_default>;
+		pinctrl-names = "default";
+		status = "okay";
It's by default, why do you need it?
Will address it in V2



Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux