On 30.05.2023 12:51, Pranavi Somisetty wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > watermark value is the minimum amount of packet data > required to activate the forwarding process. The watermark > implementation and maximum size is dependent on the device > where Cadence MACB/GEM is used. > > Signed-off-by: Pranavi Somisetty <pranavi.somisetty@xxxxxxx> > --- > Changes v2: > None (patch added in v2) > > Changes v3: > 1. Fixed DT schema error: "scalar properties shouldn't have array keywords". > 2. Modified description of rx-watermark to include units of the watermark value. > 3. Modified the DT property name corresponding to rx_watermark in > pbuf_rxcutthru to "cdns,rx-watermark". > 4. Modified commit description to remove references to Xilinx platforms, > since the changes aren't platform specific. > --- > Documentation/devicetree/bindings/net/cdns,macb.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml > index bef5e0f895be..2c733c061dce 100644 > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > @@ -109,6 +109,14 @@ properties: > power-domains: > maxItems: 1 > > + cdns,rx-watermark: > + $ref: /schemas/types.yaml#/definitions/uint16 I still think keeping this on 32 bits is still a better idea to have this DT property useable on future hardware implementation that may expand it. > + description: > + Set watermark value for pbuf_rxcutthru reg and enable > + rx partial store and forward. Watermark value here > + corresponds to number of SRAM locations. The width of SRAM is > + system dependent and can be 4,8 or 16 bytes. s/4,8/4, 8 > + > '#address-cells': > const: 1 > > @@ -166,6 +174,7 @@ examples: > compatible = "cdns,macb"; > reg = <0xfffc4000 0x4000>; > interrupts = <21>; > + cdns,rx-watermark = /bits/ 16 <0x44>; > phy-mode = "rmii"; > local-mac-address = [3a 0e 03 04 05 06]; > clock-names = "pclk", "hclk", "tx_clk"; > -- > 2.36.1 >
