On 19/05/2023 08:07, Bough Chen wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Sent: 2023年5月18日 20:10
>> To: Bough Chen <haibo.chen@xxxxxxx>; robh+dt@xxxxxxxxxx;
>> krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
>> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx
>> Cc: kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx
>> <linux-imx@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
>>
>> On 18/05/2023 10:47, haibo.chen@xxxxxxx wrote:
>>> From: Haibo Chen <haibo.chen@xxxxxxx>
>>>
>>> On imx6sll-evk board, eMMC is connect on the usdhc2.
>>
>>
>>> + pinctrl_usdhc2: usdhc2grp {
>>> + fsl,pins = <
>>> + MX6SLL_PAD_SD2_CMD__SD2_CMD 0x17059
>>> + MX6SLL_PAD_SD2_CLK__SD2_CLK 0x13059
>>> + MX6SLL_PAD_SD2_DATA0__SD2_DATA0 0x17059
>>> + MX6SLL_PAD_SD2_DATA1__SD2_DATA1 0x17059
>>> + MX6SLL_PAD_SD2_DATA2__SD2_DATA2 0x17059
>>> + MX6SLL_PAD_SD2_DATA3__SD2_DATA3 0x17059
>>> + MX6SLL_PAD_SD2_DATA4__SD2_DATA4 0x17059
>>> + MX6SLL_PAD_SD2_DATA5__SD2_DATA5 0x17059
>>> + MX6SLL_PAD_SD2_DATA6__SD2_DATA6 0x17059
>>> + MX6SLL_PAD_SD2_DATA7__SD2_DATA7 0x17059
>>> + MX6SLL_PAD_GPIO4_IO21__SD2_STROBE 0x13059
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
>>
>> No underscores in node names. Schema expects certain pattern, so be sure to
>> test it. Please run `make dtbs_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
> Hi Krzvsztof,
>
> Thanks for point that out. I will change this.
> But when I use 'make dtbs_check' to check the imx6sll-evk.dtb, though there is some issue shows up, but do not find any message point the rules "no underscores in node names".
> Anything I missing? Or this is just an implied rule？
underscores is explicit. dtc (make dtbs) with W=2 already complains
about it.
Maybe your bindings for pinctrl were not converted to DT schema? But in
such case anyway we want the same pattern for this as for other iMX schemas.
Best regards,
Krzysztof
