Hi Greg, > > Why can't this be part of the same notify_connect() callback? > > > > The notify connect is at device ready. But I want notify port status change > before port reset. > > > > > What makes it different somehow? Please document this much better. > > > > In Realtek phy driver, we have designed to dynamically adjust disconnection > level and calibrate phy parameters. > > So we do this when the device connected bit changes and when the > disconnected bit changes. > > Port status change notification: > > 1. Check if portstatus is USB_PORT_STAT_CONNECTION and portchange is > USB_PORT_STAT_C_CONNECTION. > > The device is connected, the driver lowers the disconnection level and > calibrates the phy parameters. > > 2. The device disconnects, the driver increases the disconnect level and > calibrates the phy parameters. > > > > If we adjust the disconnection level in notify_connect , the disconnect may > have been triggered at this stage. > > So we need to change that as early as possible. > > Please put this type of information in the changelog and in the comments for > the callback when you resubmit it. Okay, I will add this information at next version. Thanks, Stanley
