On 2023/5/29 22:05, Conor Dooley wrote: > Hey Changhuang, > > Couple of minor bits from me here, you don't need to fix them unless > the binding has to change for other reasons. > Thanks for your comments. [...] >> +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-rx.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive SoC MIPI D-PHY Rx Controller > > nit: either s/SoC/JH7110/ or s/SoC//. > Changed to "StarFive JH7110 SoC MIPI D-PHY Rx Controller"? >> + >> +maintainers: >> + - Jack Zhu <jack.zhu@xxxxxxxxxxxxxxxx> >> + - Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> >> + >> +description: >> + The StarFive SoC uses the MIPI CSI D-PHY based on M31 IP to transfer >> + CSI camera data. > > nit: "Starfive SoCs contain a MIPI CSI D-PHY based on an M31 IP, used to > transfer CSI camera data." > Will fixed this. >> +properties: >> + compatible: >> + const: starfive,jh7110-dphy-rx [...] >> + resets: >> + items: >> + - description: DPHY_HW reset >> + - description: DPHY_B09_ALWAYS_ON reset > > I'd prefer not to have what looks like copy-paste from a datasheet > and instead a description of what they do. > > Otherwise, this looks grand to me, but I don't understand the hardware > so there is no point in me leaving an R-b on this. > Hopefully Krzysztof can take a look at it in the coming days. > I will wait for Krzysztof's comments.
