On Mon, Dec 01, 2014 at 11:19:25AM +0800, Flora Fu wrote: > Hi, Mark, > > On Fri, 2014-11-28 at 15:30 +0000, Mark Brown wrote: > > On Fri, Nov 28, 2014 at 11:54:34AM +0800, Flora Fu wrote: > > > > > Add device tree for MT6397 regulators in mt8135.dtsi. > > > > > > Signed-off-by: Flora Fu <flora.fu@xxxxxxxxxxxx> > > > --- > > > arch/arm/boot/dts/mt8135.dtsi | 192 ++++++++++++++++++++++++++++++++++++++++++ > > > > This appears to be the DT fragment for a SoC but you are defining the > > system integration for the PMIC. That's bad, the PMIC is a separate > > device so should be hooked up by the board using it. If there's common > > elements from a reference design they should be in their own .dtsi. > > > > Do you mean that we should add a mt6397.dtsi and include it from > mt8135.dtsi? For board specific, update them in mt8135.dtsi? You can't include it from mt8135.dtsi since here you don't know if a mt6397.dtsi is connected. You have to include both the mt8135.dtsi and the mt6397.dtsi from the board file. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
