Re: [PATCH v2 0/8] RK3588 ADC support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 28/05/23 22:16, Jonathan Cameron wrote:
On Fri, 26 May 2023 02:57:04 +0530
Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx> wrote:

This patch series adds ADC support for RK3588 and updates
the DT bindings for the same.

To test ADC support on Rock 5B board, a voltage divider circuit
was created using the gpio pin 22 ( SARADC_IN4 ) and few more
tests were ran for testing the buffer and trigger support using
the iio_generic_buffer tool.

FWIW I don't have any additional comments on this beyond agreeing
those made by others need addressing.

Fingers crossed for v3.

Thanks Jonathan, I'll send a v3 after making the changes mentioned by Dmitry and Angelo.


Regards,
Shreeya Patel


Jonathan

Changes in v2
   - Add from address in patches 1 and 2.
   - Create separate patches for adding new device support and changes to
     the old device code.
   - Make use of FIELD_PREP in patch 2.
   - Move the enablement of clocks at it's original position in patch 3
   - Add Reviewed-by tag in patches 4 and 5.
   - Add an Acked-by tag in patch 8.

Shreeya Patel (8):
   iio: adc: rockchip_saradc: Add callback functions
   iio: adc: rockchip_saradc: Add support for RK3588
   iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
   iio: adc: rockchip_saradc: Use of_device_get_match_data
   iio: adc: rockchip_saradc: Match alignment with open parenthesis
   iio: adc: rockchip_saradc: Use dev_err_probe
   arm64: dts: rockchip: Add DT node for ADC support in RK3588
   dt-bindings: iio: adc: Add rockchip,rk3588-saradc string

  .../bindings/iio/adc/rockchip-saradc.yaml     |   1 +
  arch/arm64/boot/dts/rockchip/rk3588s.dtsi     |  12 +
  drivers/iio/adc/rockchip_saradc.c             | 262 +++++++++++-------
  3 files changed, 168 insertions(+), 107 deletions(-)





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux