Hi Bharat, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on groeck-staging/hwmon-next linus/master v6.4-rc3 next-20230525] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bharat-Bhushan/Watchdog-Add-marvell-GTI-watchdog-driver/20230526-142851 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230526062626.1180-2-bbhushan2%40marvell.com patch subject: [PATCH 2/2 v8] Watchdog: Add marvell GTI watchdog driver config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230528/202305280038.Fo8aOfsW-lkp@xxxxxxxxx/config) compiler: s390-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/b5f326e7e3943850db45d2f06d737dc9ac37a575 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bharat-Bhushan/Watchdog-Add-marvell-GTI-watchdog-driver/20230526-142851 git checkout b5f326e7e3943850db45d2f06d737dc9ac37a575 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=s390 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202305280038.Fo8aOfsW-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/watchdog/marvell_gti_wdt.c: In function 'gti_wdt_interrupt': >> drivers/watchdog/marvell_gti_wdt.c:89:9: error: implicit declaration of function 'writeq' [-Werror=implicit-function-declaration] 89 | writeq(GTI_CWD_INT_PENDING_STATUS(priv->wdt_timer_idx), | ^~~~~~ drivers/watchdog/marvell_gti_wdt.c: In function 'gti_wdt_start': >> drivers/watchdog/marvell_gti_wdt.c:126:18: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration] 126 | regval = readq(priv->base + GTI_CWD_WDOG(priv->wdt_timer_idx)); | ^~~~~ cc1: some warnings being treated as errors vim +/writeq +89 drivers/watchdog/marvell_gti_wdt.c 82 83 static irqreturn_t gti_wdt_interrupt(int irq, void *data) 84 { 85 struct watchdog_device *wdev = data; 86 struct gti_wdt_priv *priv = watchdog_get_drvdata(wdev); 87 88 /* Clear Interrupt Pending Status */ > 89 writeq(GTI_CWD_INT_PENDING_STATUS(priv->wdt_timer_idx), 90 priv->base + GTI_CWD_INT); 91 92 watchdog_notify_pretimeout(wdev); 93 94 return IRQ_HANDLED; 95 } 96 97 static int gti_wdt_ping(struct watchdog_device *wdev) 98 { 99 struct gti_wdt_priv *priv = watchdog_get_drvdata(wdev); 100 101 writeq(GTI_CWD_POKE_VAL, 102 priv->base + GTI_CWD_POKE(priv->wdt_timer_idx)); 103 104 return 0; 105 } 106 107 static int gti_wdt_start(struct watchdog_device *wdev) 108 { 109 struct gti_wdt_priv *priv = watchdog_get_drvdata(wdev); 110 u64 regval; 111 112 if (!wdev->pretimeout) 113 return -EINVAL; 114 115 set_bit(WDOG_HW_RUNNING, &wdev->status); 116 117 /* Clear any pending interrupt */ 118 writeq(GTI_CWD_INT_PENDING_STATUS(priv->wdt_timer_idx), 119 priv->base + GTI_CWD_INT); 120 121 /* Enable Interrupt */ 122 writeq(GTI_CWD_INT_ENA_SET_VAL(priv->wdt_timer_idx), 123 priv->base + GTI_CWD_INT_ENA_SET); 124 125 /* Set (Interrupt + SCP interrupt (DEL3T) + core domain reset) Mode */ > 126 regval = readq(priv->base + GTI_CWD_WDOG(priv->wdt_timer_idx)); 127 regval |= GTI_CWD_WDOG_MODE_INT_DEL3T_RST; 128 writeq(regval, priv->base + GTI_CWD_WDOG(priv->wdt_timer_idx)); 129 130 return 0; 131 } 132 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
