On 25.05.2023 01:04, Rudraksha Gupta wrote:
> apq8064 and msm8960 are extremely similar SoCs. Therefore copying this
> from the apq8064 dtsi file should not be a problem. Tested this on the
> Samsung Galaxy Express and this works.
>
> Signed-off-by: Rudraksha Gupta <guptarud@xxxxxxxxx>
> ---
Well admitting to this upfront doesn't sound very good :P
Please reword the message to something like:
ARM: dts: qcom-msm8960: Add USB
Add the required nodes to support USB on MSM8960.
As it's very similar to APQ8064, the setup is almost identical
As for the contents itself, I tried taking a brief peek into the
swamp that are the msm-3.0 boardfiles, but I barely managed to
escape before getting drawn into the quicksands of 13yo legacy..
I am however inclined to believe that the setup may in fact be
identical(or close to) on these two SoCs..
Konrad
> arch/arm/boot/dts/qcom-msm8960.dtsi | 33 +++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index a4d8dd2d24a6..b11e606440cd 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -3,6 +3,7 @@
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/qcom,gcc-msm8960.h>
> +#include <dt-bindings/reset/qcom,gcc-msm8960.h>
> #include <dt-bindings/clock/qcom,lcc-msm8960.h>
> #include <dt-bindings/mfd/qcom-rpm.h>
> #include <dt-bindings/soc/qcom,gsbi.h>
> @@ -370,5 +371,37 @@ gsbi1_spi: spi@16080000 {
> status = "disabled";
> };
> };
> +
> + usb1: usb@12500000 {
> + compatible = "qcom,ci-hdrc";
> + reg = <0x12500000 0x200>,
> + <0x12500200 0x200>;
> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>;
> + clock-names = "core", "iface";
> + assigned-clocks = <&gcc USB_HS1_XCVR_CLK>;
> + assigned-clock-rates = <60000000>;
> + resets = <&gcc USB_HS1_RESET>;
> + reset-names = "core";
> + phy_type = "ulpi";
> + ahb-burst-config = <0>;
> + phys = <&usb_hs1_phy>;
> + phy-names = "usb-phy";
> + status = "disabled";
> + #reset-cells = <1>;
> +
> + ulpi {
> + usb_hs1_phy: phy {
> + compatible = "qcom,usb-hs-phy-msm8960",
> + "qcom,usb-hs-phy";
> + clocks = <&sleep_clk>, <&cxo_board>;
> + clock-names = "sleep", "ref";
> + resets = <&usb1 0>;
> + reset-names = "por";
> + #phy-cells = <0>;
> + };
> + };
> + };
> +
> };
> };
