Re: [PATCH] arm64: dts: qcom: pmk8350: disable ADC by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 25.05.2023 10:34, Dmitry Baryshkov wrote:
> There is no reason to keep the vADC enabled by default. Turn it off by
> default and only reenable on the platforms which have some channels
> configured.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
Are there any drawbacks if we keep it enabled? IMO it doesn't make
sense to disable something that's on the chip just because it's unused.
It only prolongs booting by a few miliseconds and keeps a few kBs of RAM
busy, but doesn't otherwise impact anything negatively.

Konrad
>  arch/arm64/boot/dts/qcom/pmk8350.dtsi             | 1 +
>  arch/arm64/boot/dts/qcom/sc7280-idp.dts           | 2 ++
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi          | 2 ++
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi        | 2 ++
>  arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 2 ++
>  5 files changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> index bc6297e7253e..df3e916e0171 100644
> --- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> @@ -56,6 +56,7 @@ pmk8350_vadc: adc@3100 {
>  			#size-cells = <0>;
>  			interrupts = <PMK8350_SID 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>  			#io-channel-cells = <1>;
> +			status = "disabled";
>  		};
>  
>  		pmk8350_adc_tm: adc-tm@3400 {
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 15222e92e3f5..bfeeaf36546f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -73,6 +73,8 @@ &nvme_3v3_regulator {
>  };
>  
>  &pmk8350_vadc {
> +	status = "okay";
> +
>  	pmr735a-die-temp@403 {
>  		reg = <PMR735A_ADC7_DIE_TEMP>;
>  		label = "pmr735a_die_temp";
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index 21027042cf13..7c889ddf2881 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -432,6 +432,8 @@ &pcie1_phy {
>  };
>  
>  &pmk8350_vadc {
> +	status = "okay";
> +
>  	pmk8350-die-temp@3 {
>  		reg = <PMK8350_ADC7_DIE_TEMP>;
>  		label = "pmk8350_die_temp";
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index 9137db066d9e..2bae0d0ccfdd 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -383,6 +383,8 @@ &pm8350c_pwm {
>  };
>  
>  &pmk8350_vadc {
> +	status = "okay";
> +
>  	pmk8350-die-temp@3 {
>  		reg = <PMK8350_ADC7_DIE_TEMP>;
>  		label = "pmk8350_die_temp";
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 7ae6aba5d2ec..0f21bea683b7 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -515,6 +515,8 @@ &pmk8350_rtc {
>  };
>  
>  &pmk8350_vadc {
> +	status = "okay";
> +
>  	adc-chan@644 {
>  		reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>;
>  		qcom,ratiometric;



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux