On Fri, May 26, 2023 at 05:05:01PM +0800, Samin Guo wrote: > The motorcomm phy (YT8531) supports the ability to adjust the drive > strength of the rx_clk/rx_data, the value range of pad driver > strength is 0 to 7. > > Signed-off-by: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/net/motorcomm,yt8xxx.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml > index 157e3bbcaf6f..29a1997a1577 100644 > --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml > +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml > @@ -52,6 +52,18 @@ properties: > for a timer. > type: boolean > > + motorcomm,rx-clk-driver-strength: > + description: drive strength of rx_clk pad. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ] I think you should use minimum & maximum instead of these listed out enums. You have also had this comment since v1 & were reminded of it on v2 by Krzysztof: "What do the numbers mean? What are the units? mA?" This information should go into the binding, not sit in a thread on a mailing list that noone will look at when trying to write a DT :( Thanks, Conor. > + default: 3 > + > + motorcomm,rx-data-driver-strength: > + description: drive strength of rx_data/rx_ctl rgmii pad. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ] > + default: 3 > + > motorcomm,tx-clk-adj-enabled: > description: | > This configuration is mainly to adapt to VF2 with JH7110 SoC. > -- > 2.17.1 >
Attachment:
signature.asc
Description: PGP signature
