Re: [PATCH v1] ARM: dts: rockchip: Update LEDs to work with the last leds-gpio driver on radxarock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




ping :)

2014-11-23 17:20 GMT+01:00 Romain Perier <romain.perier@xxxxxxxxx>:
> See https://www.kernel.org/doc/Documentation/leds/leds-class.txt for
> LEDs device naming
>
> 2014-11-23 17:19 GMT+01:00 Romain Perier <romain.perier@xxxxxxxxx>:
>> The leds-gpio driver recently switched to the device property API. The device_node
>> name is no longer retrieved if the "label" devicetree property is not found.
>> In this case the driver tries to create entries with (null) name in
>> /sys/class/leds, which is wrong and generates backtrace as several gpio_leds have
>> the same name. Also renamed subnode "yellow" to "blue" to match the last
>> schematics updates.
>>
>> Signed-off-by: Romain Perier <romain.perier@xxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/rk3188-radxarock.dts | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts
>> index 6eb62c0..9a09579 100644
>> --- a/arch/arm/boot/dts/rk3188-radxarock.dts
>> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
>> @@ -43,16 +43,19 @@
>>                 compatible = "gpio-leds";
>>
>>                 green {
>> +                       label = "rock:green:user1";
>>                         gpios = <&gpio0 12 GPIO_ACTIVE_LOW>;
>>                         default-state = "off";
>>                 };
>>
>> -               yellow {
>> +               blue {
>> +                       label = "rock:blue:user2";
>>                         gpios = <&gpio0 14 GPIO_ACTIVE_LOW>;
>>                         default-state = "off";
>>                 };
>>
>>                 sleep {
>> +                       label = "rock:red:power";
>>                         gpios = <&gpio0 15 0>;
>>                         default-state = "off";
>>                 };
>> --
>> 1.9.1
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux