On 2023/5/26 5:34, Conor Dooley wrote: > On Thu, May 18, 2023 at 07:27:48PM +0800, Minda Chen wrote: >> StarFive JH7110 platforms USB have a wrapper module around >> the Cadence USBSS-DRD controller. Add binding information doc >> for that. >> >> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> >> Reviewed-by: Peter Chen <peter.chen@xxxxxxxxxx> >> Reviewed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> >> --- >> .../bindings/usb/starfive,jh7110-usb.yaml | 115 ++++++++++++++++++ >> 1 file changed, 115 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml >> >> diff --git a/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml b/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml >> new file mode 100644 >> index 000000000000..24aa9c10d6ab >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml >> @@ -0,0 +1,115 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/usb/starfive,jh7110-usb.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 wrapper module for the Cadence USBSS-DRD controller > > I think you told Krzysztof you'd rename this to "StarFive JH7110 Cadence > USBSS-DRD SoC controller"? > The previous title describe whole USB controller for previous dts node is merged. Now the dts node is split. "starfive,jh7110-usb" just contain starfive wrapper layer dts configuration. > Otherwise, it looks like all the stuff from him and Rob have been sorted > out, so other than $title this is > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Thanks, > Conor.. Thanks