Re: [PATCH v5 11/11] arm64: dts: renesas: rzg2l-smarc-som: Enable PMIC and built-in RTC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

Thanks for your patch!

On Mon, May 22, 2023 at 12:19 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Enable PMIC RAA215300 and the built-in RTC on the RZ/{G2L,V2L} SMARC
> EVK.

Looking at the schematics for the RZ/{G2L,G2LC,V2L} SOMs, it seems not
all SOMs have this PMIC? The ones that do have the PMIC are annotated
"PMIC Version" on the title page.

> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

> --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
> @@ -73,6 +73,13 @@ vccq_sdhi0: regulator-vccq-sdhi0 {
>                 gpios = <&pinctrl RZG2L_GPIO(39, 0) GPIO_ACTIVE_HIGH>;
>                 regulator-always-on;
>         };
> +
> +       /* 32.768kHz crystal */
> +       x2: clock-xtal {

"clock-extal" is a too generic name, and might cause conflicts.
"x2-clk"?

> +               compatible = "fixed-clock";
> +               #clock-cells = <0>;
> +               clock-frequency = <32768>;
> +       };
>  };
>
>  &adc {
> @@ -351,3 +358,14 @@ &wdt1 {
>         status = "okay";
>         timeout-sec = <60>;
>  };
> +
> +&i2c3 {

Please obey alphabetical sort order.

> +       raa215300: pmic@12 {
> +               compatible = "renesas,raa215300";
> +               reg = <0x12>, <0x6f>;
> +               reg-names = "main", "rtc";
> +
> +               clocks = <&x2>;
> +               clock-names = "xin";
> +       };
> +};
> --
> 2.25.1

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux