On 25.05.2023 20:10, Conor Dooley wrote: > On Thu, May 25, 2023 at 03:55:58PM +0300, Claudiu Beznea wrote: >> Convert Atmel PIT to YAML. Along with it clock binding has been added as >> the driver enables it to ensure proper hardware functionality. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/arm/atmel-sysregs.txt | 6 --- >> .../bindings/timer/atmel,at91sam9260-pit.yaml | 51 +++++++++++++++++++ >> 2 files changed, 51 insertions(+), 6 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt >> index 67a66bf74895..7024839c5da2 100644 >> --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt >> +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt >> @@ -4,12 +4,6 @@ Chipid required properties: >> - compatible: Should be "atmel,sama5d2-chipid" or "microchip,sama7g5-chipid" >> - reg : Should contain registers location and length >> >> -PIT Timer required properties: >> -- compatible: Should be "atmel,at91sam9260-pit" >> -- reg: Should contain registers location and length >> -- interrupts: Should contain interrupt for the PIT which is the IRQ line >> - shared across all System Controller members. >> - >> PIT64B Timer required properties: >> - compatible: Should be "microchip,sam9x60-pit64b" >> - reg: Should contain registers location and length >> diff --git a/Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.yaml b/Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.yaml >> new file mode 100644 >> index 000000000000..f304cd68acd5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.yaml >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/timer/atmel,at91sam9260-pit.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Atmel Periodic Interval Timer (PIT) >> + >> +maintainers: >> + - Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> >> + >> +description: >> + Atmel periodic interval timer provides the operating system’s scheduler >> + interrupt. It is designed to offer maximum accuracy and efficient management, >> + even for systems with long response time. >> + >> +properties: >> + compatible: >> + const: atmel,at91sam9260-pit >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + description: >> + Contain interrupt for the PIT which is the IRQ line shared across all >> + System Controller members. >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/at91.h> >> + >> + pit: timer@fffffe40 { >> + compatible = "atmel,at91sam9260-pit"; >> + reg = <0xfffffe40 0x10>; >> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > make dt_binding_check W=1 -j 30 DT_SCHEMA_FILES=atmel,at91sam9260-pit.yaml > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.example.dts > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC_CHK Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.example.dtb > Error: Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.example.dts:26.29-30 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.example.dtb] Error 1 > make: *** [Makefile:1512: dt_binding_check] Error 2 > > Think you're missing the header for IRQ_TYPE_LEVEL_HIGH > Well, I messed this series... I had the impression I've tested all these. Sorry for the noise.
