Re: [PATCH 2/3] clk: qcom: gpucc-sm8550: Add support for graphics clock controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Konrad,

Thanks for your review and sharing your changes!

On 5/20/2023 4:31 AM, Konrad Dybcio wrote:


On 19.05.2023 23:36, Jagadeesh Kona wrote:
Add support for gpucc driver on SM8550, which provides clocks for the
graphics subsystem.

Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
---
Looks like we did some duplicate work..

Please diff it against my take on the driver and check any discrepancies.


https://github.com/SoMainline/linux/commit/74320ee22f200fb21a8dbfc65aa55cf454825158

The main difference I see is your driver also have clocks under gx domain (gpu_cc_gx_*_clk) modelled, but they are really not required since there are no clients in linux voting directly on these clocks.


I also reused 8450 GPUCC (which I sent recently and is likely to get in)
bindings, you may wish to do something similar.

https://github.com/SoMainline/linux/commit/aabc4357c975f288add8b9dfa7601c5aa36f2798

Yes, will take care of this in the next series.

Konrad
  drivers/clk/qcom/Kconfig        |   8 +
  drivers/clk/qcom/Makefile       |   1 +
  drivers/clk/qcom/gpucc-sm8550.c | 609 ++++++++++++++++++++++++++++++++
  3 files changed, 618 insertions(+)
  create mode 100644 drivers/clk/qcom/gpucc-sm8550.c

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 6bb9b4aff047..b730dd9ed6b1 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -900,6 +900,14 @@ config SM_GPUCC_8350
  	  Say Y if you want to support graphics controller devices and
  	  functionality such as 3D graphics.
[skipped]

Thanks & Regards,
Jagadeesh



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux