On Fri, Nov 28, 2014 at 03:14:04PM +0100, Krzysztof Kozlowski wrote: > On pią, 2014-11-28 at 11:38 +0000, Mark Brown wrote: > > This sort of thing is a sign that we're not saving much by moving the > > parsing to the core and perhaps there's more flexiblity here... > The driver receive callbacks (or exposes other kind of interface) for > other core-generalized code. Recent example is parsing regulator mode > (added by Javier) and .of_map_mode() callback. Right, but that's actually doing some device specific translation and successfully factoring out the bulk of the code - the fact that it's taking parameters and returning data is a good sign. This is a callback placed randomly away from any other related code (adding to the confusion - it's not integrated into the rest of the flow around this at all) without a clear purpose. > I thought how to do this without this additional set_ena_gpio() call. > One way would be to extend the regulator modes (FAST/IDLE/STANDBY/ and > GPIO) but this would look somehow unnatural. Yes, that's absolutely hideous.
Attachment:
signature.asc
Description: Digital signature
