Hey Claudiu, On Tue, May 23, 2023 at 09:15:10AM +0300, Claudiu Beznea wrote: > Convert Atmel shutdown controller to YAML. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > diff --git a/Documentation/devicetree/bindings/power/reset/atmel,at91sam9260-shdwc.yaml b/Documentation/devicetree/bindings/power/reset/atmel,at91sam9260-shdwc.yaml > new file mode 100644 > index 000000000000..3b3162677db3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/atmel,at91sam9260-shdwc.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) I think you'll need an explict Ack from Rob as the text binding has no licence text. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/reset/atmel,at91sam9260-shdwc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel SHDWC Shutdown Controller > + > +maintainers: > + - Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > + > +description: | > + Atmel SHDWC shutdown controller controls the power supplies VDDIO and VDDCORE > + and the wake-up detection on debounced input lines. > + > +properties: > + compatible: > + enum: > + - atmel,at91sam9260-shdwc > + - atmel,at91sam9rl-shdwc > + - atmel,at91sam9x5-shdwc For my own curiosity, is this x a wildcard or part of the product name? Quick google was slightly confusing. > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + atmel,wakeup-mode: > + description: operation mode of the wakeup mode > + $ref: /schemas/types.yaml#/definitions/string > + enum: [ none, high, low, any ] > + > + atmel,wakeup-counter: > + description: counter on wake-up 0 > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 ] This can just be minimum: 0 maximum: 15 I think. Otherwise, looks good to me. Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
