On Fri, May 19, 2023 at 4:25 PM Paulo Pavacic <pavacic.p@xxxxxxxxx> wrote: > +//macro for writing to DSI > +#define WRITE_DSI(dsi, seq...) \ > + { \ > + const u8 d[] = { seq }; \ > + int ret = mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d)); \ > + if (ret < 0) { \ > + dev_err(&dsi->dev, \ > + "Error (%d) occurred while trying to" \ > + " write MIPI DSI command: %s (decimal value)\n", \ > + ret, d); \ > + } \ > + } As said for the other patch, this reinvents mipi_dsi_dcs_write_seq() so use that instead. mipi_dsi_dcs_write_seq(dsi, 0xFF, 0x77, 0x01, 0x00, 0x00, 0x13); etc. Yours, Linus Walleij